Remove AndroidX compatibility workarounds #86911
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blasten
added
c: contributor-productivity
flutter-dashboard
bot
added
the
tool
Contributor
|
Should you also remove from gradle.properties? At least |
22 tasks
jonahwilliams
approved these changes
Jul 23, 2021
Contributor
jonahwilliams
left a comment
jonahwilliams
left a comment
There was a problem hiding this comment.
LGTM
I believe there are some additional androidX checks as well as analytics in the code base. Should we remove all of it, or just the aar workaround here?
Author
|
Yup. This is mostly around the workarounds. The AndroidX vs non AndroidX distinction can also be removed. I will do that in the next PR. |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code was introduced to workaround AndroidX compatibilities issues back in 2019.
Related to #86802