Skip to content

Skip "newly added code executes during hot restart - canvaskit" #86885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zanderso merged 1 commit into from
Jul 22, 2021
Merged

Skip "newly added code executes during hot restart - canvaskit" #86885

zanderso merged 1 commit into from
Jul 22, 2021

Conversation

@zanderso
Copy link
Member

@zanderso zanderso commented Jul 22, 2021

@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Jul 22, 2021
@google-cla google-cla bot added the cla: yes label Jul 22, 2021
@zanderso zanderso mentioned this pull request Jul 22, 2021
Closed
jonahwilliams
jonahwilliams approved these changes Jul 22, 2021
View reviewed changes
Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zanderso
Copy link
Member Author

zanderso commented Jul 22, 2021

@jonahwilliams is there a better issue to link to for the canvaskit download issue?

@zanderso
Copy link
Member Author

zanderso commented Jul 22, 2021

Maybe @yjbanov would also know

@zanderso
Copy link
Member Author

zanderso commented Jul 22, 2021

Landing on red to green the tree.

@zanderso zanderso merged commit 10e53e9 into master Jul 22, 2021
@zanderso zanderso deleted the zanderso-patch-2 branch July 22, 2021 17:55
@annagrin annagrin mentioned this pull request Sep 20, 2021
Closed
@mdebbar mdebbar mentioned this pull request Jun 2, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@annagrin annagrin Awaiting requested review from annagrin

1 more reviewer

@jonahwilliams jonahwilliams jonahwilliams approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@zanderso @jonahwilliams