Skip to content

Conversation

@asashour
Copy link
Contributor

@asashour asashour commented Jul 22, 2021

Fixes #75094

After #86167, the remaining part is the variable name.

The main change is modifying

if (placeholder != countPlaceholder && placeholder.requiresFormatting) {

to

if (placeholder.requiresFormatting) {

The other changes are unifying duplicate conditions (with the only difference in variable).

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt.
  • All existing and new tests are passing.

@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Jul 22, 2021
@google-cla google-cla bot added the cla: yes label Jul 22, 2021
@jonahwilliams jonahwilliams requested a review from HansMuller July 22, 2021 20:41
Copy link
Contributor

@HansMuller HansMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice change!
LGTM

@HansMuller HansMuller merged commit bf132da into flutter:master Jul 22, 2021
@asashour asashour deleted the 75094_variable_name branch July 23, 2021 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[proposal] gen_l10n should support nested plurals

2 participants