Skip to content

Remove unused tiles_scroll_perf_iphonexs__timeline_summary #86822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluttergithubbot merged 1 commit into from
Jul 22, 2021
Merged

Remove unused tiles_scroll_perf_iphonexs__timeline_summary #86822

fluttergithubbot merged 1 commit into from
Jul 22, 2021

Conversation

@jmagman
Copy link
Member

@jmagman jmagman commented Jul 21, 2021

This is unused, and the same as tiles_scroll_perf_ios__timeline_summary which is on. We don't need to explicitly test iPhoneXS anymore.

Part of auditing devicelab tasks: #86802

@jmagman jmagman added a: tests "flutter test", flutter_test, or one of our tests c: contributor-productivity Team-specific productivity, code health, technical debt. c: tech-debt Technical debt, code quality, testing, etc. labels Jul 21, 2021
@jmagman jmagman self-assigned this Jul 21, 2021
@google-cla google-cla bot added the cla: yes label Jul 21, 2021
@jmagman jmagman mentioned this pull request Jul 21, 2021
Closed
22 tasks
@jmagman jmagman requested a review from jonahwilliams July 21, 2021 23:44
jonahwilliams
jonahwilliams approved these changes Jul 21, 2021
View reviewed changes
Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fluttergithubbot fluttergithubbot merged commit becd5ec into flutter:master Jul 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jonahwilliams jonahwilliams jonahwilliams approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jmagman jmagman

Labels

a: tests "flutter test", flutter_test, or one of our tests c: contributor-productivity Team-specific productivity, code health, technical debt. c: tech-debt Technical debt, code quality, testing, etc.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jmagman @jonahwilliams @fluttergithubbot