Avoid passive clipboard read on Android #86791
Conversation
Android 12 introduces a toast message that appears when an app reads the content of the clipboard. Currently, whenever there is a `TextField` widget, the app reads from the clipboard passively to determine whether the clipboard is empty and whether the "Paste" button should be shown. To avoid unintended access, always show the paste button.
flutter-dashboard
bot
added
f: material design
|
Gold has detected about 3 new digest(s) on patchset 1. |
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. For more guidance, visit Writing a golden file test for Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
@wytesk133 I checked out this branch and tried it locally. Now the three goldens failures seem to all basically look like this:
This looks like an improvement to me. I think you should accept the changes in these three goldens images 👍 . It looks like once again the blue highlight was off by one frame, and now that we're using pumpAndSettle it's showing. The cursor seems to appear correctly in both. |
|
Golden images accepted and flutter-rob passed. |
justinmc
left a comment
justinmc
left a comment
There was a problem hiding this comment.
Thanks for fixing the goldens! LGTM 👍
|
This PR introduced a failure in Google3. Reverting |
5 participants
Android 12 introduces a toast message that appears when an app reads the content of the clipboard. Currently, whenever there is a
TextFieldwidget, the app reads from the clipboard passively to determine whether the clipboard is empty and whether the "Paste" button should be shown. To avoid unintended access, always show the paste button (similar to #60316).This PR is a short-term workaround for b/192897521 and #74139. For a long-term solution, both the Flutter engine and the Flutter framework need to be updated to use the appropriate API to check whether the clipboard is empty.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.