Clarify ReorderableListView drag handles on desktop and mobile #86737
Conversation
…d mobile (v2) Prevents this flutter#80553 More info here flutter#80576 Comments only change. These changes were pre-approved on the pull 80576 but not pushed.
flutter-dashboard
bot
added
f: material design
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
This pull request executed golden file tests, but it has not been updated in a while (20+ days). Test results from Gold expire after as many days, so this pull request will need to be updated with a fresh commit in order to get results from Gold. For more guidance, visit Writing a golden file test for Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
| /// A drag handle is stacked over the center of edge on | ||
| /// [TargetPlatformVariant.desktop] platforms. On [TargetPlatformVariant.mobile] | ||
| /// platforms, no handle is visible and a long press anywhere on the item starts | ||
| /// a drag. To change this behavior use |
There was a problem hiding this comment.
instead of "use" the Flutter voice would normally say "consider"
darrenaustin
left a comment
darrenaustin
left a comment
There was a problem hiding this comment.
Sorry for the delay on this review. Thanks for the contribution, this looks good. I agree with Ian that we should probably reword that to 'consider'. Thx.
darrenaustin
left a comment
darrenaustin
left a comment
There was a problem hiding this comment.
@idkq thanks for the update. Unfortunately it looks like the analyzer didn't like the trailing space:
sdk/packages/flutter/lib/src/material/reorderable_list.dart:35: trailing U+0020 space character
Can you fix that? Then I think we should be good to go. Thx.
3 participants
Prevents this #80553
More info here #80576
Comments only change. These changes were pre-approved on the pull 80576 but not pushed.