Skip to content

Revert "Clean up the bindings APIs" #86484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
renyou merged 1 commit into from
Jul 15, 2021
Merged

Revert "Clean up the bindings APIs" #86484

renyou merged 1 commit into from
Jul 15, 2021

Conversation

@renyou
Copy link
Contributor

@renyou renyou commented Jul 15, 2021

Reverts #86438

Breaks internal tests b/193750056

@renyou renyou requested a review from Hixie July 15, 2021 15:17
@flutter-dashboard flutter-dashboard bot added a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) a: tests "flutter test", flutter_test, or one of our tests d: examples Sample code and demos f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. labels Jul 15, 2021
@google-cla google-cla bot added the cla: yes label Jul 15, 2021
goderbauer
goderbauer approved these changes Jul 15, 2021
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@renyou renyou merged commit 3dea9f0 into master Jul 15, 2021
@renyou renyou deleted the revert-86438-binding4 branch July 15, 2021 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@goderbauer goderbauer goderbauer approved these changes

@Hixie Hixie Awaiting requested review from Hixie

Assignees

No one assigned

Labels

a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) a: tests "flutter test", flutter_test, or one of our tests c: contributor-productivity Team-specific productivity, code health, technical debt. d: examples Sample code and demos f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@renyou @goderbauer