Skip to content

Revert "Clean up the bindings APIs" #86386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Hixie merged 1 commit into from
Jul 13, 2021
Merged

Revert "Clean up the bindings APIs" #86386

Hixie merged 1 commit into from
Jul 13, 2021

Conversation

@Hixie
Copy link
Contributor

@Hixie Hixie commented Jul 13, 2021

Reverts #83843 due to major breakage in devicelab.

@flutter-dashboard flutter-dashboard bot added a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) a: tests "flutter test", flutter_test, or one of our tests d: examples Sample code and demos f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. labels Jul 13, 2021
@google-cla google-cla bot added the cla: yes label Jul 13, 2021
@Hixie
Copy link
Contributor Author

Hixie commented Jul 13, 2021

landing without review since it reverts the immediately-prior commit.
landing on red to fix tree.

@Hixie Hixie merged commit c800b9c into master Jul 13, 2021
@Hixie Hixie deleted the revert-83843-binding2 branch July 13, 2021 22:47
This was referenced Jul 13, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) a: tests "flutter test", flutter_test, or one of our tests c: contributor-productivity Team-specific productivity, code health, technical debt. d: examples Sample code and demos f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Hixie