-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Add fixes for AppBar deprecations #86382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
SystemUiOverlayStyle requires import 'package:flutter/services.dart'; see flutter/gallery#531 which applied the gallery changes.
darrenaustin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Looks like there are some test failures that Hans had some insight into.
|
Thanks! Yeah, I can add the import with the fix! :) |
|
So, I added the import, just like we have in another fix, but it is for some reason resulting in ~1000 import statements after running the fix. 🙃 @bwilkerson is there something wrong here? Output: |
|
This pull request executed golden file tests, but it has not been updated in a while (20+ days). Test results from Gold expire after as many days, so this pull request will need to be updated with a fresh commit in order to get results from Gold. For more guidance, visit Writing a golden file test for Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
This pull request is not suitable for automatic merging in its current state.
|
|
Not sure why flutter_svg would be broken by this. Checked it out locally with/without this change and the test failure persists, cc @dnfield |
|
Looks like it may be related to an engine change - does it help if you merge up to head? |
|
This is up to date as of 30 minutes ago, the failure has persisted for a few days now of merging master a couple of times. |
|
Synced again.. |
|
Caught up with @dnfield offline, this failure does not appear to make sense with this change, I am going to open a fresh PR to see if it resolves itself. |
|
New PR is #88365 |
This adds fixes for the deprecations added in #86198
Fixes #74908
It also adds a few missing deprecation notices to the affected api.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.