Enable landscape mode in Flutter Gallery (iOS) #8638
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Already enabled on Android.
Member
Author
chinmaygarde
approved these changes
Mar 8, 2017
Member
chinmaygarde
left a comment
chinmaygarde
left a comment
There was a problem hiding this comment.
Cool. I didn't know the gallery supported landscape.
Member
Author
|
According to @Hixie this is relatively recent (for particular definitions of 'relatively' and 'recent'). I didn't take a look at the commit history to see where it happened. |
Member
Author
|
Looks like I broke the Mac buildbot. Build: |
Contributor
|
The gallery has always "supported" landscape. It's just that many things are buggy in landscape mode. But the time has come where we can't really hide behind turning it off any more and we just need to deal with it. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 22, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 22, 2019
This was referenced Apr 22, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 22, 2019
engine-flutter-autoroll
added a commit
that referenced
this pull request
Apr 22, 2019
flutter/engine@206cab6...ea28bfa git log 206cab6..ea28bfa --no-merges --oneline ea28bfa Custom RTL handling for ghost runs, NotoNaskhArabic test font (flutter/engine#8683) 1c9457c Revert "Only allow mappings for ICU initialization. (#8656)" (flutter/engine#8682) b4ed303 Revert "RTL handling for ghost runs, NotoNaskhArabic test font (#8638)" (flutter/engine#8681) 8b5f776 Remove support for downloading dynamic patches. (flutter/engine#8663) 1bcb96b Add framework test in engine presubmit checks (flutter/engine#8664) 6e79dcd RTL handling for ghost runs, NotoNaskhArabic test font (flutter/engine#8638) c37d459 Roll src/third_party/skia 1c0b05afdef8..a76fad2d494a (4 commits) (flutter/engine#8665) 2e4f0a4 Put the testing lib in the flutter namespace. (flutter/engine#8661) 1239df9 Allow native bindings in secondary isolates. (flutter/engine#8658) b0cbce4 Replace ThreadLocal with ThreadLocalUniquePtr<T> (flutter/engine#8659) bd8c5b1 Only allow mappings for ICU initialization. (flutter/engine#8656) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff ([email protected]), and stop the roller if necessary.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Already enabled on Android.