Skip to content

AppBar.backwardsCompatibility now default false, deprecated #86198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
HansMuller merged 6 commits into from
Jul 12, 2021
Merged

AppBar.backwardsCompatibility now default false, deprecated #86198

HansMuller merged 6 commits into from
Jul 12, 2021

Conversation

@HansMuller
Copy link
Contributor

@HansMuller HansMuller commented Jul 9, 2021 •
edited
Loading

Deprecate AppBar.brightness, AppBar.backwardsCompatibility, SliverAppBar.brightness, SliverAppBar.backwardsCompatibility, AppBarTheme.brightness, AppBarTheme.backwardsCompatibility, and AppBarTheme.textTheme. The default value of AppBar.backwardsCompatibility is now false.

This is a follow-on to #71184 which substantially revised AppBar and added the backwardsCompatibility flag to give developers time to migrate.

Fixes #86127

@flutter-dashboard
Copy link

flutter-dashboard bot commented Jul 9, 2021

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Jul 9, 2021
@google-cla google-cla bot added the cla: yes label Jul 9, 2021
@HansMuller HansMuller changed the title AppBar.backwardsCompatibility now default false, deprecated [Draft] AppBar.backwardsCompatibility now default false, deprecated Jul 9, 2021
@flutter-dashboard flutter-dashboard bot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Jul 9, 2021
This was referenced Jul 10, 2021
Merged
Merged
@HansMuller HansMuller requested a review from darrenaustin July 12, 2021 18:01
@HansMuller HansMuller changed the title [Draft] AppBar.backwardsCompatibility now default false, deprecated AppBar.backwardsCompatibility now default false, deprecated Jul 12, 2021
darrenaustin
darrenaustin approved these changes Jul 12, 2021
View reviewed changes
Copy link
Contributor

@darrenaustin darrenaustin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

packages/flutter/test/material/app_bar_test.dart Outdated
Copy link
Contributor

@darrenaustin darrenaustin Jul 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the empty line here?

Copy link
Contributor Author

@HansMuller HansMuller Jul 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, good catch. I'd forgotten to commit some local changes.

@HansMuller HansMuller force-pushed the deprecate_appbar_backwards_compatibility_flag branch from 6d90bad to 53b2857 Compare July 12, 2021 18:30
@HansMuller HansMuller mentioned this pull request Jul 12, 2021
Closed
@HansMuller HansMuller merged commit 3eca034 into flutter:master Jul 12, 2021
@HansMuller HansMuller deleted the deprecate_appbar_backwards_compatibility_flag branch July 12, 2021 20:38
@Piinks
Copy link
Contributor

Piinks commented Jul 12, 2021

These should have dart fixes with them.

This was referenced Jul 12, 2021
Closed
Closed
renyou added a commit that referenced this pull request Jul 15, 2021
@renyou
Revert "AppBar.backwardsCompatibility now default false, deprecated (#…
4929837 
…86198)"

This reverts commit 3eca034.
@renyou renyou mentioned this pull request Jul 15, 2021
Closed
@HansMuller HansMuller mentioned this pull request Aug 4, 2021
Closed
8 tasks
@Piinks Piinks mentioned this pull request Aug 17, 2021
Merged
8 tasks
@Renzo-Olivares Renzo-Olivares mentioned this pull request Jan 26, 2023
Merged
8 tasks
@QuncCccccc QuncCccccc mentioned this pull request Feb 13, 2023
Merged
8 tasks
@LongCatIsLooong LongCatIsLooong mentioned this pull request Feb 13, 2023
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@darrenaustin darrenaustin darrenaustin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt. f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Documentation] AppBarTheme toolbarTextStyle and titleTextStyle documentation not following the current behavior

3 participants

@HansMuller @Piinks @darrenaustin