Skip to content

Conversation

@yjbanov
Copy link
Contributor

@yjbanov yjbanov commented Jul 8, 2021

  • Consolidate all web integration tests under flutter/flutter/dev/integration_tests/web_e2e_tests
  • Add failure_test.dart from package:integration_test to the CI
  • Catch errors from the web driver callback and report them in a format that FlutterDriver understands and can print to the logs in a debuggable way

Design doc: https://docs.google.com/document/d/15hI36xAt05XZQR35jQXNqcPSQRhcROjqAMZ20PAnJ1E

Progress towards:

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Jul 8, 2021
@google-cla google-cla bot added the cla: yes label Jul 8, 2021
@yjbanov yjbanov force-pushed the web-e2e-tests branch 2 times, most recently from a9c6a48 to 83faa16 Compare July 8, 2021 21:09
@yjbanov yjbanov requested a review from Piinks as a code owner July 8, 2021 21:33
@yjbanov yjbanov force-pushed the web-e2e-tests branch 3 times, most recently from 6d8962c to 02b60e9 Compare July 9, 2021 18:20
@yjbanov yjbanov requested a review from dnfield July 9, 2021 18:53
Copy link
Contributor

@dnfield dnfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

integration test changes LGTM, @jiahaog fyi

@yjbanov yjbanov merged commit 78e06e7 into flutter:master Jul 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants