Skip to content

Conversation

@darrenaustin
Copy link
Contributor

@darrenaustin darrenaustin commented Jul 7, 2021

Part of #84014.

This migrates the devicelab tests and test runners to null safety. With this everything in the device lab should be running with null safety turned on.

@flutter-dashboard flutter-dashboard bot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Jul 7, 2021
@google-cla google-cla bot added the cla: yes label Jul 7, 2021
Copy link
Contributor

@justinmc justinmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@darrenaustin
Copy link
Contributor Author

Just pulled in the latest from the other PRs that landed recently.

This is still currently blocked by a bug in vm_service: dart-lang/sdk#46559, which will have to be resolved and rolled into flutter master before this can land.

@darrenaustin darrenaustin merged commit 8fcace1 into flutter:master Jul 23, 2021
@darrenaustin darrenaustin deleted the null_devicelab_tests branch July 23, 2021 20:39
@darrenaustin darrenaustin restored the null_devicelab_tests branch July 23, 2021 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants