Migrate devicelab tasks a-f to null safety. #85996
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
a: accessibility
This was referenced Jul 7, 2021
darrenaustin
changed the title
justinmc
approved these changes
Jul 7, 2021
Contributor
justinmc
left a comment
justinmc
left a comment
There was a problem hiding this comment.
LGTM 👍
But it looks like the analyzer is failing due to importing other non-nullsafe stuff in flutter_devicelab.
Contributor
Author
Thanks for the review. Yeah, this will need the core framework from the device lab (#85993) to land first and then I will merge it with this before committing. |
darrenaustin
added a commit
that referenced
this pull request
Jul 12, 2021
This reverts commit 9d3563a.
darrenaustin
added a commit
that referenced
this pull request
Jul 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #85995.
Migrate the first 3rd of the devicelab tasks to null safety.
This will require the core framework migration #85993 to land first in order for the tests to pass.