Skip to content

Revert "Support iOS arm64 simulator" #85641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jmagman merged 1 commit into from
Jun 30, 2021
Merged

Revert "Support iOS arm64 simulator" #85641

jmagman merged 1 commit into from
Jun 30, 2021

Conversation

@zanderso
Copy link
Member

@zanderso zanderso commented Jun 30, 2021

Reverts #85059

Looks like a test needs an update to a path:

https://ci.chromium.org/ui/p/flutter/builders/prod/Mac%20build_ios_framework_module_test/3171/overview

Task result:
{
  "success": false,
  "reason": "FileSystemException: Expected file to exist., path = '/opt/s/w/ir/x/t/flutter_module_test.8Wd6Go/hello_module/flutter-frameworks/Profile/App.xcframework/ios-x86_64-simulator/App.framework/Info.plist'"
}

@zanderso zanderso requested a review from jmagman June 30, 2021 19:43
@flutter-dashboard flutter-dashboard bot added c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels. labels Jun 30, 2021
@google-cla google-cla bot added the cla: yes label Jun 30, 2021
jmagman
jmagman approved these changes Jun 30, 2021
View reviewed changes
Copy link
Member

@jmagman jmagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmagman
Copy link
Member

jmagman commented Jun 30, 2021

Merging to green the tree.

@jmagman jmagman merged commit 407916d into master Jun 30, 2021
@jmagman jmagman deleted the revert-85059-arm64-sim branch June 30, 2021 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jmagman jmagman jmagman approved these changes

Assignees

No one assigned

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@zanderso @jmagman