Added AppBar.textButtonTheme #85585
Merged
Added AppBar.textButtonTheme #85585
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
f: material design
darrenaustin
approved these changes
Jun 30, 2021
Contributor
darrenaustin
left a comment
darrenaustin
left a comment
There was a problem hiding this comment.
LGTM. Nice addition.
Contributor
Author
|
This change caused some unintended diffs with AppBars with a white background - where the default TextButton colors already contrasted well with the AppBar's background color. Internal Google bug b/192498505 I am going to temporarily revert this change. |
HansMuller
pushed a commit
that referenced
this pull request
Jul 1, 2021
This reverts commit fdeb480.
fluttergithubbot
pushed a commit
that referenced
this pull request
Jul 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, TextButtons included in the AppBar's title or actions widgets will use the AppBar's foregroundColor as their foreground color. Apps can override the default by specifying
appBar.textButtonThemeor by overriding the theme'sThemeData.appBarTheme, or by styling the individual buttons.This TextButton-specific tweak is useful because, by default, the foreground color for TextButtons is
ColorScheme.primary, which is the also the default background color for AppBar. The rationale for including this property and its default is the same as for the default values ofAppBar.iconThemeandAppBar.actionsIconTheme. The theme's for other widgets (or the app's overall color scheme) are not overridden by default because they're not commonly found in AppBars.Fixes #84642