Skip to content

Migrate dev/benchmarks/macrobenchmarks to null safety. #85501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
darrenaustin merged 1 commit into from
Jun 29, 2021
Merged

Migrate dev/benchmarks/macrobenchmarks to null safety. #85501

darrenaustin merged 1 commit into from
Jun 29, 2021

Conversation

@darrenaustin
Copy link
Contributor

@darrenaustin darrenaustin commented Jun 29, 2021

For #84014

@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. c: contributor-productivity Team-specific productivity, code health, technical debt. labels Jun 29, 2021
@google-cla google-cla bot added the cla: yes label Jun 29, 2021
@darrenaustin darrenaustin mentioned this pull request Jun 29, 2021
Closed
27 tasks
@darrenaustin darrenaustin added the a: null-safety Support for Dart's null safety feature label Jun 29, 2021
@shihaohong shihaohong self-assigned this Jun 29, 2021
@shihaohong shihaohong self-requested a review June 29, 2021 14:46
@shihaohong shihaohong removed their assignment Jun 29, 2021
shihaohong
shihaohong reviewed Jun 29, 2021
View reviewed changes
Copy link
Contributor

@shihaohong shihaohong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything look good, I just had a quick question about one variable that might be non-nullable.

@darrenaustin darrenaustin requested a review from yjbanov June 29, 2021 18:42
shihaohong
shihaohong approved these changes Jun 29, 2021
View reviewed changes
Copy link
Contributor

@shihaohong shihaohong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@darrenaustin darrenaustin merged commit 37bc722 into flutter:master Jun 29, 2021
@darrenaustin darrenaustin deleted the macrobenchmarks_null branch June 29, 2021 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yjbanov yjbanov Awaiting requested review from yjbanov

1 more reviewer

@shihaohong shihaohong shihaohong approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

a: null-safety Support for Dart's null safety feature c: contributor-productivity Team-specific productivity, code health, technical debt. f: material design flutter/packages/flutter/material repository.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@darrenaustin @shihaohong