Check ios-arm64_x86_64-simulator directory when validating codesigning entitlement #85265
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmagman
added
c: contributor-productivity
jmagman
commented
Jun 24, 2021
| fileSystem | ||
| .directory(xcframeworkPath) | ||
| .childDirectory('ios-x86_64-simulator') | ||
| .childDirectory('ios-arm64_x86_64-simulator') |
Member
Author
There was a problem hiding this comment.
The changes to this file aren't strictly related to the codesign issue, but may as well change them together.
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The engine Flutter frameworks are now building for arm64 iOS simulator as of recipe change https://flutter-review.googlesource.com/c/recipes/+/14780. Change the codesigning script to match the new path names.
See #85053 for similar fix.