Skip to content

Migrate flutter_cache to null safety - #85242

Merged
fluttergithubbot merged 4 commits into
flutter:masterfrom
jmagman:flutter-cache-null
Jun 25, 2021
Merged

fluttergithubbot merged 4 commits into
flutter:masterfrom
jmagman:flutter-cache-null

Conversation

@jmagman

@jmagman jmagman commented Jun 24, 2021

Copy link
Copy Markdown
Member

Part of #71511

@jmagman jmagman added c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels. a: null-safety Support for Dart's null safety feature labels Jun 24, 2021
@jmagman jmagman self-assigned this Jun 24, 2021
@flutter-dashboard

Copy link
Copy Markdown

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@google-cla google-cla Bot added the cla: yes label Jun 24, 2021
@jmagman
jmagman force-pushed the flutter-cache-null branch from f229154 to 0d19769 Compare June 24, 2021 19:18
@jmagman
jmagman requested a review from jonahwilliams June 24, 2021 21:10

@jonahwilliams jonahwilliams left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with nit

@fluttergithubbot

Copy link
Copy Markdown
Contributor

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite Linux analyze has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite analyze-linux has failed. Please fix the issues identified (or deflake) before re-applying this label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a: null-safety Support for Dart's null safety feature c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants