Repository navigation
[flutter_tools] retry chrome launch up to 3 times - #85162
Merged
fluttergithubbot merged 2 commits intoJun 24, 2021
Merged
Conversation
flutter-dashboard
Bot
added
the
tool
zanderso
reviewed
Jun 24, 2021
zanderso
left a comment
zanderso
left a comment
Member
There was a problem hiding this comment.
Does this help with any particular issue that we have filed?
| 'Chrome or Edge. Otherwise, consider using -d web-server instead ' | ||
| 'and filing an issue at https://github.com/flutter/flutter/issues.', | ||
| ); | ||
| if (retry >= 3) { |
Member
There was a problem hiding this comment.
Pull 3 up out of the loop to a named constant. kMaxRetries
Contributor
Author
|
the issue is around here somewhere... |
zanderso
approved these changes
Jun 24, 2021
Contributor
|
This pull request is not suitable for automatic merging in its current state.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of only retrying chrome launch on the glibc bug, just retry up to 3 times to see if it can pass
Fixes #83899