macOS unzip then rsync to delete stale artifacts #85075
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmagman
added
platform-ios
gw280
reviewed
Jun 22, 2021
Lofterheit
approved these changes
Jun 22, 2021
jonahwilliams
approved these changes
Jun 22, 2021
Contributor
jonahwilliams
left a comment
jonahwilliams
left a comment
There was a problem hiding this comment.
LGTM
We already require rsync and unzip on macOS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On macOS only, when unzipping, first unzip to a temp directory, then
rsyncwith the--deleteflag so stale files that aren't in the target directory are deleted, and files continue to only be updated as needed. This adds an extra I/O copy step to unzipping, but will make sure deleted archive files are actually deleted. This applies for downloading cached artifacts as well as unzipping prebuilt macOS and iOS app bundles.Confirmed that the stale xcframework architecture triple directories are removed on this PR (more details in #85062)
Fixes #85062
There was a previous attempt to do this at #74818 but that only seems to delete
flutter/bin/cache/artifacts/engine/ios/artifacts(which doesn't exist), notflutter/bin/cache/artifacts/engine/ios/*