Skip to content

Support iOS arm64 simulator #85059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jmagman merged 1 commit into from
Jun 30, 2021
Merged

Support iOS arm64 simulator #85059

jmagman merged 1 commit into from
Jun 30, 2021

Conversation

@jmagman
Copy link
Member

@jmagman jmagman commented Jun 22, 2021 •
edited
Loading

The iOS engine Flutter.framework artifacts now contains both ARM and x86_64 architecture slices.

More integration test support will be added when M1 Macs are available for testing #79430.

Reverts #85051
Fixes #64502
Fixes #69334
Fixes #74970
Fixes #79641

@jmagman jmagman added the platform-ios iOS applications specifically label Jun 22, 2021
@jmagman jmagman self-assigned this Jun 22, 2021
@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Jun 22, 2021
@google-cla google-cla bot added the cla: yes label Jun 22, 2021
@jmagman jmagman mentioned this pull request Jun 22, 2021
Closed
@jmagman jmagman mentioned this pull request Jun 23, 2021
Closed
@jmagman jmagman marked this pull request as ready for review June 23, 2021 01:48
@flutter-dashboard flutter-dashboard bot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Jun 23, 2021
@jmagman jmagman requested review from gw280 and jonahwilliams June 23, 2021 02:01
@jmagman jmagman added the platform-host-arm Building on an ARM-based platform label Jun 23, 2021
@jmagman jmagman mentioned this pull request Jun 23, 2021
Closed
jonahwilliams
jonahwilliams approved these changes Jun 23, 2021
View reviewed changes
Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Cocoapods is RSLGTM

@jmagman
Copy link
Member Author

jmagman commented Jun 23, 2021

I'm going to hold off merging this until we can get some CI validation with #79430

@jmagman jmagman mentioned this pull request Jun 29, 2021
Closed
@jmagman
Copy link
Member Author

jmagman commented Jun 30, 2021

I'm going to hold off merging this until we can get some CI validation with #79430

Discussed with Zach, going to merge this and at least validate this doesn't break the x86_64 macs. When the ARM macs come online in infra we will get additional validation.

FRoB is currently down, the Google testing is an unrelated flake. Merging.

@jmagman jmagman merged commit a102051 into flutter:master Jun 30, 2021
@jmagman jmagman deleted the arm64-sim branch June 30, 2021 18:56
zanderso added a commit that referenced this pull request Jun 30, 2021
@zanderso
Revert "Support iOS arm64 simulator (#85059)"
52d158a 
This reverts commit a102051.
@zanderso zanderso mentioned this pull request Jun 30, 2021
Merged
jmagman pushed a commit that referenced this pull request Jun 30, 2021
@zanderso
Revert "Support iOS arm64 simulator (#85059)" (#85641)
407916d 
This reverts commit a102051.
jmagman added a commit to jmagman/flutter that referenced this pull request Jun 30, 2021
@jmagman
Support iOS arm64 simulator (flutter#85059)
a7e6a2d
@jmagman jmagman mentioned this pull request Jun 30, 2021
Merged
@stenlee
Copy link

stenlee commented Jul 1, 2021

Great news! Looking forward to see this in Stable channel 👍👍👍

@jmagman jmagman mentioned this pull request Aug 20, 2021
Closed
@Zelfapp Zelfapp mentioned this pull request Aug 21, 2021
Closed
@ollyde
Copy link

ollyde commented Aug 25, 2021 •
edited
Loading

@jmagman thanks for your hard work. Will this be pushed in 2.3 or something? I'm still seeing this bug; it's very annoying. Reference to original issue #79641

@jmagman
Copy link
Member Author

jmagman commented Aug 25, 2021

@jmagman thanks for your hard work. Will this be pushed in 2.3 or something? I'm still seeing this bug; it's very annoying. Reference to original issue #79641

This fix is in 2.4.0-4.0.pre, which is currently available in the beta channel.

@jmagman jmagman mentioned this pull request Sep 8, 2021
Closed
@jmagman jmagman mentioned this pull request Oct 4, 2021
Closed
@jmagman jmagman mentioned this pull request Oct 14, 2021
Closed
@jmagman jmagman mentioned this pull request Mar 3, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@gw280 gw280 gw280 approved these changes

@jonahwilliams jonahwilliams jonahwilliams approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jmagman jmagman

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt. platform-host-arm Building on an ARM-based platform platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

5 participants

@jmagman @stenlee @ollyde @gw280 @jonahwilliams