Skip to content

macos support for image_list #84899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluttergithubbot merged 4 commits into from
Apr 21, 2022
Merged

macos support for image_list #84899

fluttergithubbot merged 4 commits into from
Apr 21, 2022

Conversation

@Abhishek01039
Copy link
Contributor

@Abhishek01039 Abhishek01039 commented Jun 19, 2021

part of #84306

@flutter-dashboard flutter-dashboard bot added d: examples Sample code and demos c: contributor-productivity Team-specific productivity, code health, technical debt. labels Jun 19, 2021
@google-cla google-cla bot added the cla: yes label Jun 19, 2021
@Abhishek01039
Copy link
Contributor Author

Abhishek01039 commented Jul 6, 2021

Hello @Piinks
can you please review this PR?
Thanks

@Piinks
Copy link
Contributor

Piinks commented Jul 7, 2021

Hi @Abhishek01039 I do not know that I am the best reviewer for this PR, I recommend inquiring in the #hackers-ios channel for review. :) Thanks for the contribution!

@jmagman jmagman added the platform-mac Building on or for macOS specifically label Jul 23, 2021
@cbracken cbracken added the a: desktop Running on desktop label Jul 26, 2021
@Hixie
Copy link
Contributor

Hixie commented Aug 29, 2021

Would it make sense to have a test that verifies that we have the right files for each of the examples? In case we ever add another platform or another example or whatnot.

@Hixie Hixie mentioned this pull request Aug 29, 2021
Closed
8 tasks
@jmagman
Copy link
Member

jmagman commented Sep 7, 2021

Hi @Abhishek01039 I do not know that I am the best reviewer for this PR, I recommend inquiring in the #hackers-ios channel for review. :) Thanks for the contribution!

@Piinks for future reference #hackers-desktop, this is adding support for macOS desktop, not iOS. 😄

@jmagman
Copy link
Member

jmagman commented Sep 7, 2021

/cc @cbracken

@gspencergoog gspencergoog self-requested a review September 9, 2021 18:08
@cbracken cbracken self-requested a review September 30, 2021 18:37
@cbracken
Copy link
Member

cbracken commented Jan 12, 2022

Apologies for the delay on this; I expect to have time to review this in the coming week. Thanks for your patience.

@Abhishek01039
Copy link
Contributor Author

Abhishek01039 commented Jan 17, 2022

Sure, thank you @cbracken

@gspencergoog gspencergoog removed their request for review March 2, 2022 20:49
cbracken
cbracken approved these changes Apr 21, 2022
View reviewed changes
Copy link
Member

@cbracken cbracken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for the delay; this LGTM.

@fluttergithubbot
Copy link
Contributor

fluttergithubbot commented Apr 21, 2022

This pull request is not suitable for automatic merging in its current state.

  • Please get at least one approved review if you are already a member or two member reviews if you are not a member before re-applying this label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

@cbracken cbracken requested a review from gspencergoog April 21, 2022 18:48
gspencergoog
gspencergoog approved these changes Apr 21, 2022
View reviewed changes
Copy link
Contributor

@gspencergoog gspencergoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

@fluttergithubbot fluttergithubbot merged commit ab889ab into flutter:master Apr 21, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 21, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 21, 2022
@engine-flutter-autoroll
ab889ab macos support for image_list (flutter/flutter#84899)
babf677
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 26, 2022
@engine-flutter-autoroll
ab889ab macos support for image_list (flutter/flutter#84899)
86f40eb
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 26, 2022
@engine-flutter-autoroll
ab889ab macos support for image_list (flutter/flutter#84899)
3ca2def
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 26, 2022
@engine-flutter-autoroll
ab889ab macos support for image_list (flutter/flutter#84899)
a3d9385
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 26, 2022
@engine-flutter-autoroll
ab889ab macos support for image_list (flutter/flutter#84899)
dee17dd
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 26, 2022
@engine-flutter-autoroll
ab889ab macos support for image_list (flutter/flutter#84899)
8e503d9
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 26, 2022
@engine-flutter-autoroll
ab889ab macos support for image_list (flutter/flutter#84899)
921cb85
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 26, 2022
@engine-flutter-autoroll
ab889ab macos support for image_list (flutter/flutter#84899)
0eccf80
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 26, 2022
@engine-flutter-autoroll
ab889ab macos support for image_list (flutter/flutter#84899)
4b98467
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 26, 2022
@engine-flutter-autoroll
ab889ab macos support for image_list (flutter/flutter#84899)
8ede09b
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 26, 2022
@engine-flutter-autoroll
ab889ab macos support for image_list (flutter/flutter#84899)
00b837c
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 26, 2022
@engine-flutter-autoroll
ab889ab macos support for image_list (flutter/flutter#84899)
6d2b404
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
ab889ab macos support for image_list (flutter/flutter#84899)
b1c838c
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
ab889ab macos support for image_list (flutter/flutter#84899)
779689c
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
ab889ab macos support for image_list (flutter/flutter#84899)
20ee588
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
ab889ab macos support for image_list (flutter/flutter#84899)
f7b5af4
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
ab889ab macos support for image_list (flutter/flutter#84899)
17fd180
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
ab889ab macos support for image_list (flutter/flutter#84899)
578bd01
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
ab889ab macos support for image_list (flutter/flutter#84899)
ac97382
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
ab889ab macos support for image_list (flutter/flutter#84899)
1d3e98b
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
ab889ab macos support for image_list (flutter/flutter#84899)
8f87610
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
ab889ab macos support for image_list (flutter/flutter#84899)
950b708
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
ab889ab macos support for image_list (flutter/flutter#84899)
cd5261e
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
ab889ab macos support for image_list (flutter/flutter#84899)
a9eeb9f
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
ab889ab macos support for image_list (flutter/flutter#84899)
52b70da
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
ab889ab macos support for image_list (flutter/flutter#84899)
b2259c9
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
ab889ab macos support for image_list (flutter/flutter#84899)
bed8a00
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
ab889ab macos support for image_list (flutter/flutter#84899)
b3d9fae
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 28, 2022
@engine-flutter-autoroll
ab889ab macos support for image_list (flutter/flutter#84899)
6049c16
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 28, 2022
@engine-flutter-autoroll
ab889ab macos support for image_list (flutter/flutter#84899)
ba36a5b
egramond pushed a commit to egramond/flutter that referenced this pull request May 5, 2022
@Abhishek01039 @egramond
macos support for image_list (flutter#84899)
a3ee34b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cbracken cbracken cbracken approved these changes

@gspencergoog gspencergoog gspencergoog approved these changes

Assignees

No one assigned

Labels

a: desktop Running on desktop c: contributor-productivity Team-specific productivity, code health, technical debt. d: examples Sample code and demos platform-mac Building on or for macOS specifically

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@Abhishek01039 @Piinks @Hixie @jmagman @cbracken @fluttergithubbot @gspencergoog