Skip to content

Audit devicelab log streaming for nullability #84820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluttergithubbot merged 1 commit into from
Jun 18, 2021
Merged

Audit devicelab log streaming for nullability #84820

fluttergithubbot merged 1 commit into from
Jun 18, 2021

Conversation

@jmagman
Copy link
Member

@jmagman jmagman commented Jun 18, 2021

Audit some nullability assumptions from #84008 that aren't right when running tests locally.

  1. hostAgent.dumpDirectory is now nullable. Handle that, and move flutter drive --screenshot flag logic into flutterCommandArgs.
  2. Handle null _loggingProcess and log sink when running tests locally.

Fixes #84819

@jmagman jmagman added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Jun 18, 2021
@jmagman jmagman self-assigned this Jun 18, 2021
@flutter-dashboard flutter-dashboard bot added the a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) label Jun 18, 2021
@google-cla google-cla bot added the cla: yes label Jun 18, 2021
@jmagman jmagman mentioned this pull request Jun 18, 2021
Merged
@jmagman jmagman requested review from dnfield and jonahwilliams June 18, 2021 00:50
dnfield
dnfield approved these changes Jun 18, 2021
View reviewed changes
Copy link
Contributor

@dnfield dnfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fluttergithubbot fluttergithubbot merged commit 03034e9 into flutter:master Jun 18, 2021
@jmagman jmagman deleted the host-agent-directory branch June 18, 2021 16:47
@jmagman jmagman added the a: null-safety Support for Dart's null safety feature label Aug 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jonahwilliams jonahwilliams Awaiting requested review from jonahwilliams

1 more reviewer

@dnfield dnfield dnfield approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jmagman jmagman

Labels

a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) a: null-safety Support for Dart's null safety feature c: contributor-productivity Team-specific productivity, code health, technical debt.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Some devicelab tests are crashing locally, IosDevice.stopLoggingToSink NoSuchMethodError: The method 'kill' was called on null.

3 participants

@jmagman @dnfield @fluttergithubbot