Primary scroll view support for SingleChildScrollView #8437
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hixie
reviewed
Feb 27, 2017
| assert(primary != null); | ||
| assert(controller == null || !primary, | ||
| 'Primary ScrollViews obtain their ScrollController via inheritance from a PrimaryScrollController widget. ' | ||
| 'You cannot both set primary to true and pass an explicit controller.'); |
Contributor
There was a problem hiding this comment.
nit: missing newline before )
Contributor
There was a problem hiding this comment.
looks like i screwed that up in scroll_view.dart too
Contributor
|
LGTM if you add a test |
Member
Author
|
Added! |
tvolkert
reviewed
Mar 1, 2017
| this.scrollDirection: Axis.vertical, | ||
| this.reverse: false, | ||
| this.padding, | ||
| this.primary: false, |
Contributor
There was a problem hiding this comment.
Side-note: our widget constructors need dartdoc (I was gonna say this param should be documented, only to realize the whole constructor needs to be documented :-))
Contributor
There was a problem hiding this comment.
Yes, the scrolling classes are missing many dartdocs. It's on my list for this week.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.