Repository navigation
fix a PlatformView gesture bug - #84257
Conversation
flutter-dashboard
Bot
added
the
framework
| _pointerData(ui.PointerChange.move, const Offset(10, 10), pointer: 1, kind: PointerDeviceKind.touch), | ||
| _pointerData(ui.PointerChange.remove, const Offset(10, 10), pointer: 1, kind: PointerDeviceKind.touch), | ||
| ])); | ||
| async.flushMicrotasks(); |
There was a problem hiding this comment.
does this test need to expect something?
There was a problem hiding this comment.
According to the original issue, it does not need to expect anything, but only not throw any errors. I usually include the following line for such cases:
// Passes if no crashes.
There was a problem hiding this comment.
if possible, I'd try to test this logic explicitly: https://github.com/flutter/flutter/pull/84257/files#diff-02ee737d0b04265db456b12d3e7c3499b84e321bcc8d3a8e4e30757b6cba3e94R544-R546
| pointerProperties.clear(); | ||
| usedAndroidPointerIds.clear(); | ||
| downTimeMillis = null; | ||
| _remove(event.pointer); |
There was a problem hiding this comment.
a comment would be helpful: "pointer cancel is handled like pointer up. Normally, the difference is that pointer cancel doesn't perform any action, but in this case neither up or cancel perform any action".
|
|
||
| }, skip: isBrowser); // TODO(yjbanov): fails on Web with obscured stack trace: https://github.com/flutter/flutter/issues/42770 | ||
|
|
||
| // Regression test for https://github.com/flutter/flutter/issues/69431 |
There was a problem hiding this comment.
did you confirm that reverting the changes in platform_views.dart causes this test to fail?
There was a problem hiding this comment.
Yes,this can reproduce the issue.
Piinks
added
e: device-specific
|
Try to land to the master branch. |
|
Awesome work! Thank you @xu-baolin |
Continue work of #82013
Fixes #69431