Skip to content

Re-land "Migrate android_semantics_testing to null safety (#84136)" #84156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluttergithubbot merged 2 commits into from
Jun 7, 2021
Merged

Re-land "Migrate android_semantics_testing to null safety (#84136)" #84156

fluttergithubbot merged 2 commits into from
Jun 7, 2021

Conversation

@goderbauer
Copy link
Member

@goderbauer goderbauer commented Jun 7, 2021 •
edited
Loading

Reverts #84154

Unfortunately, I wasn't able to reproduce the failure locally. I suspect it's a race condition and added a waitFor to the test to hopefully avoid it (see second commit with changes over original PR).

@flutter-dashboard flutter-dashboard bot added a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) c: contributor-productivity Team-specific productivity, code health, technical debt. labels Jun 7, 2021
@google-cla google-cla bot added the cla: yes label Jun 7, 2021
@goderbauer goderbauer requested a review from darrenaustin June 7, 2021 22:26
darrenaustin
darrenaustin approved these changes Jun 7, 2021
View reviewed changes
Copy link
Contributor

@darrenaustin darrenaustin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just looked at the changes from the previous PR. LGTM.

@goderbauer goderbauer changed the title Revert null semantics Re-land "Migrate android_semantics_testing to null safety (#84136)" Jun 7, 2021
@goderbauer goderbauer mentioned this pull request Jun 7, 2021
Closed
27 tasks
@fluttergithubbot fluttergithubbot merged commit 0100285 into flutter:master Jun 7, 2021
darrenaustin added a commit that referenced this pull request Jun 8, 2021
@darrenaustin
Revert "Re-land "Migrate android_semantics_testing to null safety (#8…
9c29ac4 
…4136)" (#84156)"

This reverts commit 0100285.
@darrenaustin darrenaustin mentioned this pull request Jun 8, 2021
Merged
darrenaustin added a commit that referenced this pull request Jun 8, 2021
@darrenaustin
Revert "Re-land "Migrate android_semantics_testing to null safety (#8…
80709c1 
…4136)" (#84156)" (#84166)

This reverts commit 0100285.
@Piinks Piinks added a: null-safety Support for Dart's null safety feature c: tech-debt Technical debt, code quality, testing, etc. labels Jun 9, 2021
This was referenced Sep 21, 2021
Merged
Closed
@goderbauer goderbauer deleted the revertNullSemantics branch March 3, 2023 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@darrenaustin darrenaustin darrenaustin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) a: null-safety Support for Dart's null safety feature c: contributor-productivity Team-specific productivity, code health, technical debt. c: tech-debt Technical debt, code quality, testing, etc.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@goderbauer @darrenaustin @Piinks @fluttergithubbot