Skip to content

Revert "Migrate android_semantics_testing to null safety (#84136)" #84154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
darrenaustin merged 1 commit into from
Jun 7, 2021
Merged

Revert "Migrate android_semantics_testing to null safety (#84136)" #84154

darrenaustin merged 1 commit into from
Jun 7, 2021

Conversation

@darrenaustin
Copy link
Contributor

@darrenaustin darrenaustin commented Jun 7, 2021

This reverts commit 0d1a8a7.

This appears to be breaking the build:

https://ci.chromium.org/ui/p/flutter/builders/prod/Mac_android%20android_semantics_integration_test/1441/overview

with:

[android_semantics_integration_test] [STDOUT] stdout: [ +101 ms] 00:38 �[32m+9�[0m: AccessibilityBridge Headings AppBar title has correct Android heading semantics�[0m
[android_semantics_integration_test] [STDOUT] stdout: [ +290 ms] {}
[android_semantics_integration_test] [STDOUT] stdout: [   +4 ms] 00:38 �[32m+9�[0m�[31m -1�[0m: AccessibilityBridge Headings AppBar title has correct Android heading semantics �[1m�[31m[E]�[0m�[0m
[android_semantics_integration_test] [STDOUT] stdout: [        ]   Null check operator used on a null value

@flutter-dashboard flutter-dashboard bot added a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) c: contributor-productivity Team-specific productivity, code health, technical debt. labels Jun 7, 2021
@darrenaustin darrenaustin requested a review from goderbauer June 7, 2021 21:46
@google-cla google-cla bot added the cla: yes label Jun 7, 2021
Piinks
Piinks approved these changes Jun 7, 2021
View reviewed changes
Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@darrenaustin darrenaustin merged commit 094a75e into flutter:master Jun 7, 2021
@darrenaustin darrenaustin deleted the access_revert branch June 7, 2021 21:54
goderbauer added a commit to goderbauer/flutter that referenced this pull request Jun 7, 2021
@goderbauer
Revert "Revert "Migrate android_semantics_testing to null safety (flu…
6134065 
…tter#84136)" (flutter#84154)"

This reverts commit 094a75e.
@goderbauer goderbauer mentioned this pull request Jun 7, 2021
Merged
@goderbauer goderbauer mentioned this pull request Aug 30, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Piinks Piinks Piinks approved these changes

@goderbauer goderbauer Awaiting requested review from goderbauer

Assignees

No one assigned

Labels

a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) c: contributor-productivity Team-specific productivity, code health, technical debt.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@darrenaustin @Piinks