Skip to content

Conversation

@goderbauer
Copy link
Member

For #84014

This one found an actual bug in the framework.

@flutter-dashboard flutter-dashboard bot added framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. labels Jun 7, 2021
@google-cla google-cla bot added the cla: yes label Jun 7, 2021
@goderbauer goderbauer requested a review from Piinks June 7, 2021 19:57
Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flutter_LGTM

&& (decoded[1] == null || decoded[1] is String))
throw PlatformException(
code: decoded[0] as String,
message: decoded[1] as String,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NICE

@fluttergithubbot fluttergithubbot merged commit c077278 into flutter:master Jun 7, 2021
@Piinks Piinks added a: null-safety Support for Dart's null safety feature c: tech-debt Technical debt, code quality, testing, etc. labels Jun 9, 2021
@goderbauer goderbauer deleted the channels_null_sfaety branch March 3, 2023 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a: null-safety Support for Dart's null safety feature c: contributor-productivity Team-specific productivity, code health, technical debt. c: tech-debt Technical debt, code quality, testing, etc. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants