Skip to content

Migrate android_semantics_testing to null safety #84136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
goderbauer merged 1 commit into from
Jun 7, 2021
Merged

Migrate android_semantics_testing to null safety #84136

goderbauer merged 1 commit into from
Jun 7, 2021

Conversation

@goderbauer
Copy link
Member

@goderbauer goderbauer commented Jun 7, 2021

For #84014.

@flutter-dashboard flutter-dashboard bot added a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) c: contributor-productivity Team-specific productivity, code health, technical debt. labels Jun 7, 2021
@google-cla google-cla bot added the cla: yes label Jun 7, 2021
@goderbauer goderbauer requested a review from jonahwilliams June 7, 2021 19:06
@goderbauer goderbauer mentioned this pull request Jun 7, 2021
Closed
27 tasks
jonahwilliams
jonahwilliams approved these changes Jun 7, 2021
View reviewed changes
Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@goderbauer goderbauer merged commit 0d1a8a7 into flutter:master Jun 7, 2021
@goderbauer goderbauer deleted the android_semantics_testing_null branch June 7, 2021 20:53
darrenaustin added a commit that referenced this pull request Jun 7, 2021
@darrenaustin
Revert "Migrate android_semantics_testing to null safety (#84136)" (#…
094a75e 
…84154)

This reverts commit 0d1a8a7.
goderbauer added a commit to goderbauer/flutter that referenced this pull request Jun 7, 2021
@goderbauer
Revert "Revert "Migrate android_semantics_testing to null safety (flu…
6134065 
…tter#84136)" (flutter#84154)"

This reverts commit 094a75e.
fluttergithubbot pushed a commit that referenced this pull request Jun 7, 2021
@goderbauer
Re-land "Migrate android_semantics_testing to null safety (#84136)" (#…
0100285 
…84156)
darrenaustin added a commit that referenced this pull request Jun 8, 2021
@darrenaustin
Revert "Re-land "Migrate android_semantics_testing to null safety (#8…
9c29ac4 
…4136)" (#84156)"

This reverts commit 0100285.
darrenaustin added a commit that referenced this pull request Jun 8, 2021
@darrenaustin
Revert "Re-land "Migrate android_semantics_testing to null safety (#8…
80709c1 
…4136)" (#84156)" (#84166)

This reverts commit 0100285.
@Piinks Piinks added a: null-safety Support for Dart's null safety feature c: tech-debt Technical debt, code quality, testing, etc. labels Jun 9, 2021
@darrenaustin darrenaustin mentioned this pull request Sep 23, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jonahwilliams jonahwilliams jonahwilliams approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) a: null-safety Support for Dart's null safety feature c: contributor-productivity Team-specific productivity, code health, technical debt. c: tech-debt Technical debt, code quality, testing, etc.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@goderbauer @jonahwilliams @Piinks