Skip to content

Add TextInputType.none #83974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluttergithubbot merged 3 commits into from
Jun 29, 2021
Merged

Add TextInputType.none #83974

fluttergithubbot merged 3 commits into from
Jun 29, 2021

Conversation

@jpnurmi
Copy link
Member

@jpnurmi jpnurmi commented Jun 4, 2021 •
edited
Loading

TextInputType.none makes it possible to disable the virtual keyboard for individual TextFields, and lays the foundations for custom in-app virtual keyboards (#76072).

This is just the framework part that merely introduces the TextInputType.none enum value. For the actual functionality, the engine needs to be adapted for all platforms to respect TextInputType.none when passed in the text input configuration.

Closes: #83567

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt.
  • All existing and new tests are passing.

@jpnurmi
Add TextInputType.none
813d17c 
TextInputType.none makes it possible to disable the virtual keyboard
for certain TextFields, and lays the foundations for custom in-app
virtual keyboards (flutter#76072).

Ref: flutter#83567
@flutter-dashboard flutter-dashboard bot added the framework flutter/packages/flutter repository. See also f: labels. label Jun 4, 2021
@google-cla google-cla bot added the cla: yes label Jun 4, 2021
This was referenced Jun 4, 2021
Merged
Merged
Closed
Merged
@Piinks Piinks added the a: text input Entering text in a text field or keyboard related problems label Jun 10, 2021
@jpnurmi jpnurmi mentioned this pull request Jun 15, 2021
Closed
9 tasks
@fanchou fanchou mentioned this pull request Jun 15, 2021
Closed
LongCatIsLooong
LongCatIsLooong approved these changes Jun 16, 2021
View reviewed changes
Copy link
Contributor

@LongCatIsLooong LongCatIsLooong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'll hold off until the engine changes are LGTM'd.

@jpnurmi
Copy link
Member Author

jpnurmi commented Jun 29, 2021

I suppose there's not much we can do on Windows at this point. TextInput.show and TextInput.hide do nothing: https://github.com/flutter/engine/blob/2384128a226c6661844c247a31204235372a81e6/shell/platform/windows/text_input_plugin.cc#L148. There seems to be a ticket about it: #36057

@jpnurmi
Copy link
Member Author

jpnurmi commented Jun 29, 2021

On macOS, the Accessibility Keyboard is a persistent floating top-level window, and its visibility is controlled by the user. So nothing to do on macOS either?

justinmc
justinmc approved these changes Jun 29, 2021
View reviewed changes
Copy link
Contributor

@justinmc justinmc left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Looks like the analyzer is down or something? It's not able to run.

Edit: Windows and Mac seem ok to me also. I would think it's desired that the user can still control an accessibility keyboard even if a Mac app has implemented a custom virtual keyboard using this feature.

@LongCatIsLooong
Copy link
Contributor

LongCatIsLooong commented Jun 29, 2021

@jpnurmi Could you try merging/rebasing the branch to the tip of the tree?

@fluttergithubbot fluttergithubbot merged commit 0967a40 into flutter:master Jun 29, 2021
@jpnurmi jpnurmi deleted the text-input-type-none branch June 30, 2021 06:22
This was referenced Jul 1, 2021
Closed
Closed
@taosif7-dreamorbit
Copy link

taosif7-dreamorbit commented Mar 23, 2023

If keyboardType is given TextInputType.none and autofocus is true, it doesn't let enter any text.

@r3flow r3flow mentioned this pull request Dec 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@justinmc justinmc justinmc approved these changes

@LongCatIsLooong LongCatIsLooong LongCatIsLooong approved these changes

Assignees

No one assigned

Labels

a: text input Entering text in a text field or keyboard related problems framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add TextInputType.none

6 participants

@jpnurmi @LongCatIsLooong @taosif7-dreamorbit @justinmc @Piinks @fluttergithubbot