Add barrierDismissable argument to showDialog #8397
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
xster
approved these changes
Feb 24, 2017
Member
There was a problem hiding this comment.
What about just defaulting to false?
In some situations, dialogs don't want the barrier to be dismissable. Fixes flutter#8354
Hixie
reviewed
Feb 24, 2017
| this.theme, | ||
| }); | ||
| @required this.theme, | ||
| bool barrierDismissable: true, |
Contributor
There was a problem hiding this comment.
doesn't matter what the default is, this is only called from one place and that place lists the argument.
Contributor
Author
There was a problem hiding this comment.
That's true, but we might as well have ergonomic private APIs.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 2, 2019
engine-flutter-autoroll
added a commit
that referenced
this pull request
Apr 2, 2019
flutter/engine@6675f71...f7b4903 git log 6675f71..f7b4903 --no-merges --oneline f7b4903 Revert "Separate the data required to bootstrap the VM into its own class. (#8397)" (flutter/engine#8406) f835789 Roll src/third_party/skia d962070feb84..70d8f4f3acbb (1 commits) (flutter/engine#8405) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff ([email protected]), and stop the roller if necessary.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 4, 2019
…M into its own class. (flutter#8397)" (flutter#8406)" (flutter/engine#8414)
This was referenced Apr 4, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 4, 2019
…M into its own class. (flutter#8397)" (flutter#8406)" (flutter/engine#8414)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 4, 2019
…M into its own class. (flutter#8397)" (flutter#8406)" (flutter/engine#8414)
engine-flutter-autoroll
added a commit
that referenced
this pull request
Apr 4, 2019
flutter/engine@309d078...ad9d241 git log 309d078..ad9d241 --no-merges --oneline ad9d241 Roll src/third_party/skia dde12a25bb5e..f346df396a23 (1 commits) (flutter/engine#8438) 0ed237c Roll src/third_party/skia b6d04556c34d..dde12a25bb5e (4 commits) (flutter/engine#8437) 445ab42 Roll src/third_party/dart 11a3dd7332..600b2831ef (9 commits) 49d0dc6 Roll src/third_party/skia 5c5de2146309..b6d04556c34d (1 commits) (flutter/engine#8434) 4ff18fb Roll src/third_party/dart f6768b6fb3..11a3dd7332 (56 commits) 7b83198 Roll src/third_party/skia 2273c900ea28..5c5de2146309 (5 commits) (flutter/engine#8432) 800ea0a Revert "Enable shutting down all root isolates in a VM. (#8402)" (flutter/engine#8431) b59c443 Enable shutting down all root isolates in a VM. (flutter/engine#8402) 9acdf18 Make AccessibilityViewEmbedder final (flutter/engine#8429) 804d54d Eliminate unused displayBounds parameter (flutter/engine#8427) d4c815f Roll buildroot (flutter/engine#8425) 20190d7 Roll src/third_party/skia fbe240669394..2273c900ea28 (13 commits) (flutter/engine#8428) 7e38b0a Revert "Revert "Separate the data required to bootstrap the VM into its own class. (#8397)" (#8406)" (flutter/engine#8414) d8bb9d7 Roll src/third_party/skia 176da0bb8a10..fbe240669394 (9 commits) (flutter/engine#8424) 64fc583 Remove use of DART_CHECK_VALID. (flutter/engine#8417) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff ([email protected]), and stop the roller if necessary.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some situations, dialogs don't want the barrier to be dismissable.
Fixes #8354