FYI @Hixie .

Oh, haha, good catch.

I'd like to find a way to test this without adding a devicelab test, but I'm scratching my head a bit right now

Soliciting testing ideas:

I can't turn off asserts in our unit tests, so I can't show that the extension is still registered.
I can't run a profile build in the tool integration tests, the flutter_tester only supports debug
I could add a new devicelab test to verify devtools connects, but sometimes devtools fails to activate on CI and I'm certain this would be flaky.

I can't think of a way to really test this other than an end-to-end test in devicelab either.

Maybe the first step is to fix the flakiness. :-)

(In the meantime you could also make the test pass in the case where it fails to bootstrap devtools, since we already test that in existing tests. Can a test decide midway through itself that it should be skipped?)

Yeah, I think that's what we have to do. if its flaky we can revisit.

I added a devicelab test, will add to infra config after this lands