Skip to content

Revert "fix a Scaffold.bottomSheet update bug" #83904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
angjieli merged 1 commit into from
Jun 3, 2021
Merged

Revert "fix a Scaffold.bottomSheet update bug" #83904

angjieli merged 1 commit into from
Jun 3, 2021

Conversation

@angjieli
Copy link
Contributor

@angjieli angjieli commented Jun 3, 2021

This PR breaks several Google tests.
Reverts #83689

@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Jun 3, 2021
@google-cla google-cla bot added the cla: yes label Jun 3, 2021
@angjieli angjieli requested a review from HansMuller June 3, 2021 16:03
HansMuller
HansMuller approved these changes Jun 3, 2021
View reviewed changes
Copy link
Contributor

@HansMuller HansMuller left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The source of the problem seems to be obscured because the error message is trying to print a deactivated widget's state: "Looking up a deactivated widget's ancestor is unsafe...."

Will investigate.

Internal google bug b/189965268

HansMuller
HansMuller approved these changes Jun 3, 2021
View reviewed changes
Copy link
Contributor

@HansMuller HansMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Piinks
Copy link
Contributor

Piinks commented Jun 3, 2021

FYI @xu-baolin who authored the change

@angjieli angjieli merged commit 14f0079 into master Jun 3, 2021
@angjieli angjieli deleted the revert-83689-0601happyChildrensDay branch June 3, 2021 16:44
@xu-baolin xu-baolin mentioned this pull request Jun 4, 2021
Closed
@xu-baolin
Copy link
Member

xu-baolin commented Jun 10, 2021

@HansMuller Hi, any news about the internal tests?

@HansMuller
Copy link
Contributor

HansMuller commented Jun 10, 2021

Sorry: investigating why the internal tests failed is on my queue; just haven't been able to get to it yet. Sorry about the delay.

@xu-baolin
Copy link
Member

xu-baolin commented Jun 11, 2021

Got it. Thanks a lot.

@xu-baolin xu-baolin mentioned this pull request Jun 29, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@HansMuller HansMuller HansMuller approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@angjieli @Piinks @xu-baolin @HansMuller