Skip to content

migrate complex layout to null safety #83894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluttergithubbot merged 5 commits into from
Jun 9, 2021
Merged

migrate complex layout to null safety #83894

fluttergithubbot merged 5 commits into from
Jun 9, 2021

Conversation

@Abhishek01039
Copy link
Contributor

@Abhishek01039 Abhishek01039 commented Jun 3, 2021 •
edited
Loading

Migrate complex_layout to null safety
Related to #84014

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) c: contributor-productivity Team-specific productivity, code health, technical debt. labels Jun 3, 2021
@google-cla google-cla bot added the cla: yes label Jun 3, 2021
@goderbauer
Copy link
Member

goderbauer commented Jun 7, 2021

Looks like the analyzer is not happy. Can you take a look?

@goderbauer goderbauer mentioned this pull request Jun 7, 2021
Closed
27 tasks
@Abhishek01039
Copy link
Contributor Author

Abhishek01039 commented Jun 9, 2021

Now CI has passed. @goderbauer

@Abhishek01039 Abhishek01039 requested a review from goderbauer June 9, 2021 02:23
shihaohong
shihaohong reviewed Jun 9, 2021
View reviewed changes
@Abhishek01039 Abhishek01039 requested a review from shihaohong June 9, 2021 16:40
Piinks
Piinks approved these changes Jun 9, 2021
View reviewed changes
Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for the contribution!

@Piinks Piinks added a: null-safety Support for Dart's null safety feature c: tech-debt Technical debt, code quality, testing, etc. waiting for tree to go green labels Jun 9, 2021
@fluttergithubbot fluttergithubbot merged commit 92e3436 into flutter:master Jun 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Piinks Piinks Piinks approved these changes

@goderbauer goderbauer Awaiting requested review from goderbauer

@shihaohong shihaohong Awaiting requested review from shihaohong

Assignees

No one assigned

Labels

a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) a: null-safety Support for Dart's null safety feature c: contributor-productivity Team-specific productivity, code health, technical debt. c: tech-debt Technical debt, code quality, testing, etc.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Abhishek01039 @goderbauer @Piinks @shihaohong @fluttergithubbot