Skip to content

fix a Scaffold.bottomSheet update bug #83689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluttergithubbot merged 1 commit into from
Jun 2, 2021
Merged

fix a Scaffold.bottomSheet update bug #83689

fluttergithubbot merged 1 commit into from
Jun 2, 2021

Conversation

@xu-baolin
Copy link
Member

@xu-baolin xu-baolin commented Jun 1, 2021

fixes #83668

  // It is possible that the fade-out animation of the sheet has not finished
  // yet, and the key needs to be regenerated at this time, otherwise, there will
  // be an exception of duplicate GlobalKey.

@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Jun 1, 2021
@google-cla google-cla bot added the cla: yes label Jun 1, 2021
@xu-baolin xu-baolin requested a review from Piinks June 1, 2021 05:11
@nt4f04uNd
Copy link
Member

nt4f04uNd commented Jun 1, 2021 •
edited
Loading

What if we remove the key, just save the setState callback?

@xu-baolin
Copy link
Member Author

xu-baolin commented Jun 1, 2021

What if we remove the key, just save the setState callback?

The effect is the same, but it is not routine to do that in the framework, but it is often done in tests. ^ ^

HansMuller
HansMuller approved these changes Jun 2, 2021
View reviewed changes
Copy link
Contributor

@HansMuller HansMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Piinks
Piinks approved these changes Jun 2, 2021
View reviewed changes
Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flutter_LGTM

@fluttergithubbot fluttergithubbot merged commit 9a243a1 into flutter:master Jun 2, 2021
angjieli added a commit that referenced this pull request Jun 3, 2021
@angjieli
Revert "fix a Scaffold.bottomSheet update bug (#83689)"
8f2c6d6 
This reverts commit 9a243a1.
@angjieli angjieli mentioned this pull request Jun 3, 2021
Merged
angjieli added a commit that referenced this pull request Jun 3, 2021
@angjieli
Revert "fix a Scaffold.bottomSheet update bug (#83689)" (#83904)
14f0079 
This reverts commit 9a243a1.
@xu-baolin xu-baolin mentioned this pull request Jun 29, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Piinks Piinks Piinks approved these changes

+1 more reviewer

@HansMuller HansMuller HansMuller approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Scaffold.bottomSheet throws a duplicate GlobalKey when being quickly removed/added to the Scaffold

5 participants

@xu-baolin @nt4f04uNd @HansMuller @Piinks @fluttergithubbot