Migrate build system build.dart to null safety #83381
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmagman
added
c: contributor-productivity
jmagman
commented
May 26, 2021
| line = mapFunction(line); | ||
| mappedLine = mapFunction(line); | ||
| } | ||
| if (line != null) { |
Member
Author
There was a problem hiding this comment.
This listener handled null values returned from mapFunction.
jmagman
commented
May 26, 2021
| snapshotterPath += '_' + getNameForDarwinArch(darwinArch!); | ||
| } | ||
|
|
||
| return _processUtils.stream( |
Member
Author
There was a problem hiding this comment.
Line 77 is the null returned from mapFunction that prompted that signature change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make build.dart null safe.
Update processUtils.stream to handle a null return from
mapFunctionto indicate no line should be printed, since that's how it's used in a few places. Add a unit test for this.flutter/packages/flutter_tools/lib/src/android/gradle.dart
Lines 410 to 416 in 33b183e
Also found a few
globals_null_migratedimports I missed.Part of #71511
Closes #81106