Skip to content

[versions] roll package test redux #83367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jonahwilliams merged 8 commits into from
May 27, 2021
Merged

[versions] roll package test redux #83367

jonahwilliams merged 8 commits into from
May 27, 2021

Conversation

@jonahwilliams
Copy link
Contributor

@jonahwilliams jonahwilliams commented May 25, 2021 •
edited
Loading

Fixes #81516
Fixes #81834
Fixes #81294

Redo of #82275

@jonahwilliams jonahwilliams requested a review from Piinks as a code owner May 25, 2021 19:36
@flutter-dashboard
Copy link

flutter-dashboard bot commented May 25, 2021

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@flutter-dashboard flutter-dashboard bot added c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels. labels May 25, 2021
@google-cla google-cla bot added the cla: yes label May 25, 2021
@jonahwilliams jonahwilliams requested a review from zanderso May 25, 2021 20:16
zanderso
zanderso approved these changes May 25, 2021
View reviewed changes
Copy link
Member

@zanderso zanderso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jonahwilliams
Copy link
Contributor Author

jonahwilliams commented May 26, 2021

Looks like we're having trouble pulling in new versions of several plugins. I'll file a bug tomorrow and pin

@mit-mit mit-mit mentioned this pull request May 26, 2021
Closed
@christopherfujino christopherfujino mentioned this pull request May 26, 2021
Closed
@jonahwilliams jonahwilliams merged commit 025a3a7 into flutter:master May 27, 2021
@jonahwilliams jonahwilliams deleted the roll_test_asdasasd branch May 27, 2021 00:22
@mit-mit
Copy link
Member

mit-mit commented May 27, 2021

Very nice, thanks!

@jmagman jmagman mentioned this pull request Jan 12, 2022
Merged
@Hixie Hixie mentioned this pull request Aug 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zanderso zanderso zanderso approved these changes

@Piinks Piinks Awaiting requested review from Piinks

Assignees

No one assigned

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

3 participants

@jonahwilliams @mit-mit @zanderso