Skip to content

Revert "Roll Engine from 490068230f9a to c118a134fb11 (3 revisions) (…#82500

Merged
jmagman merged 1 commit into
flutter:masterfrom
cbracken:revert-engine-roll
May 14, 2021
Merged

Revert "Roll Engine from 490068230f9a to c118a134fb11 (3 revisions) (…#82500
jmagman merged 1 commit into
flutter:masterfrom
cbracken:revert-engine-roll

Conversation

@cbracken

@cbracken cbracken commented May 14, 2021

Copy link
Copy Markdown
Member

#82486)"

Revert engine roll which was reliably crashing the devicelab
linux_android_view_scroll_perf__timeline_summary test.

Example crashes:

This appears to be related to
flutter-team-archive/engine#25900 which is being reverted in
flutter-team-archive/engine#26142.

This reverts commit 1af31d8.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard Bot added the engine flutter/engine related. See also e: labels. label May 14, 2021
@google-cla google-cla Bot added the cla: yes label May 14, 2021

@christopherfujino christopherfujino left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmagman

jmagman commented May 14, 2021

Copy link
Copy Markdown
Member

GTMLogger TAP failure looks unrelated, marking tests as passing in FRoB.

@jmagman

jmagman commented May 14, 2021

Copy link
Copy Markdown
Member

Fixes #82505.
Merging to green the tree.

@jmagman
jmagman merged commit 7beec2a into flutter:master May 14, 2021
@cbracken
cbracken deleted the revert-engine-roll branch May 14, 2021 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

engine flutter/engine related. See also e: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants