Skip to content

Make the StockHome TabBar selection persistent #824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
HansMuller merged 1 commit into from
Dec 9, 2015
Merged

Make the StockHome TabBar selection persistent #824

HansMuller merged 1 commit into from
Dec 9, 2015

Conversation

@HansMuller
Copy link
Contributor

@HansMuller HansMuller commented Dec 8, 2015

Fixes #671

@abarth
Copy link
Contributor

abarth commented Dec 9, 2015

This isn't the right fix. We should teach TabBar how to persist this data in PageStorage. Check out how Scrollable saves its scroll offset.

@HansMuller
Copy link
Contributor Author

HansMuller commented Dec 9, 2015

TabBar doesn't own its TabBarSelection the app or page does. In this case I think StockHome would be the logical owner, so I can have it use PageStorage to save the TabBarSelection.

@abarth
Copy link
Contributor

abarth commented Dec 9, 2015

LGTM

@Hixie
Copy link
Contributor

Hixie commented Dec 9, 2015

Can the TabBarSelection actually be an Inherited widget in the tree itself? Then the tab bar and tab view could crawl up a bit instead of being given a TabBarSelection; and the TabBarSelection could crawl up and find the page storage.

@HansMuller
Copy link
Contributor Author

HansMuller commented Dec 9, 2015

Making the TabBarSelection an InheritedWidget sounds like the right thing to do. If it's OK with you, I'll commit this change, just to fix the bug, and then do the inherited widget.

@Hixie
Copy link
Contributor

Hixie commented Dec 9, 2015

Oh sure there's no reason to do that in this PR. Feel free to just file a bug for it too.

@HansMuller HansMuller mentioned this pull request Dec 9, 2015
Closed
@HansMuller
Copy link
Contributor Author

HansMuller commented Dec 9, 2015

TabBarSelection should be an InheritedWidget
#835

HansMuller pushed a commit that referenced this pull request Dec 9, 2015
Merge pull request #824 from HansMuller/save_tabs_selection
b42ac4e 
Make the StockHome TabBar selection persistent

Fixes #671
@HansMuller HansMuller merged commit b42ac4e into flutter:master Dec 9, 2015
@HansMuller HansMuller deleted the save_tabs_selection branch December 9, 2015 17:57
@FlutterIssues FlutterIssues mentioned this pull request Dec 17, 2015
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Tabs forget which tab there were showing

3 participants

@HansMuller @abarth @Hixie