Skip to content

Add flutter_tools to trigger list for skp_generator #82239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluttergithubbot merged 1 commit into from
May 12, 2021
Merged

Add flutter_tools to trigger list for skp_generator #82239

fluttergithubbot merged 1 commit into from
May 12, 2021

Conversation

@Hixie
Copy link
Contributor

@Hixie Hixie commented May 11, 2021

Turns out that since skp_generator relies on flutter create, we need to make sure we trigger precommit tests on changes to flutter_tools too.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@Hixie
Add flutter_tools to trigger list for skp_generator
b40996a 
Turns out that since skp_generator relies on `flutter create`, we need to make sure we trigger precommit tests on changes to flutter_tools too.
@flutter-dashboard flutter-dashboard bot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label May 11, 2021
@google-cla google-cla bot added the cla: yes label May 11, 2021
@Hixie
Copy link
Contributor Author

Hixie commented May 11, 2021

cc @goderbauer

This was referenced May 11, 2021
Merged
Merged
dnfield
dnfield approved these changes May 11, 2021
View reviewed changes
Copy link
Contributor

@dnfield dnfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

goderbauer
goderbauer approved these changes May 11, 2021
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks!

@fluttergithubbot fluttergithubbot merged commit 59d3b32 into master May 12, 2021
@fluttergithubbot fluttergithubbot deleted the Hixie-patch-3 branch May 12, 2021 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@goderbauer goderbauer goderbauer approved these changes

+1 more reviewer

@dnfield dnfield dnfield approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Hixie @goderbauer @dnfield @fluttergithubbot