Popup menu custom padding #81996
Popup menu custom padding #81996
Conversation
flutter-dashboard
bot
added
f: material design
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
Moluram
force-pushed
the
popup-menu-custom-padding
branch
from
66dc109 to
6a3dc2f
Compare
|
Hi @Moluram it looks like there are some merge conflicts here, would you like to take a look and update this PR? |
…adding # Conflicts: # packages/flutter/lib/src/material/popup_menu.dart
|
Hello @darrenaustin! |
|
Any update on this? |
|
What's the status of this PR? |
@Moluram I am so sorry it has taken me so long to get to this. Unfortunately it looks like it is has been long enough that there is another merge conflict with what is currently in master. If you are still up for it, can you update to the latest on master? I promise I will act on this when it is ready to go. If not, I understand and we can try to get this into the tree some other way. Thx. |
|
@darrenaustin I opened a new PR with the same changes applied on the latest master branch. The PR is hopefully updated now |
|
@darrenaustin we can close this |
|
How can I set the _kMenuScreenPadding? |
|
SInce this issue is not solved yet, I open a new one #143512. |
This comment was marked as spam.
This comment was marked as spam.
## Description This PR exposed `PopupMenuButton.menuPadding` parameter to override the hardcoded value. Credits to @Moluram for the original PR #81996. And to @arafaysaleem for the update in #96657. #96657 was reverted due to a Google testing failure. `PopupMenuButton` implementation has evolved since that time so maybe we will not hit this Google testing failure. And if we do, we will try to figure out what is going on. ## Related Issue Fixes #143512. Fixes #57110 ## Tests Adds 2 tests, updates several tests.
## Description This PR exposed `PopupMenuButton.menuPadding` parameter to override the hardcoded value. Credits to @Moluram for the original PR flutter#81996. And to @arafaysaleem for the update in flutter#96657. flutter#96657 was reverted due to a Google testing failure. `PopupMenuButton` implementation has evolved since that time so maybe we will not hit this Google testing failure. And if we do, we will try to figure out what is going on. ## Related Issue Fixes flutter#143512. Fixes flutter#57110 ## Tests Adds 2 tests, updates several tests.
8 participants
Provides ability to change PopupMenuButton popup menu padding.
Fixes #57110.
This is my first PR! It's really great to participate in such a big project :)
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.