Skip to content

[reland] Adding vscode path installed via snap #81989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluttergithubbot merged 5 commits into from
May 12, 2021
Merged

[reland] Adding vscode path installed via snap #81989

fluttergithubbot merged 5 commits into from
May 12, 2021

Conversation

@TahaTesser
Copy link
Member

@TahaTesser TahaTesser commented May 6, 2021 •
edited
Loading

Relands #54415

Closes #54358

Before

VS Code installed via Snap isn't detected.

After

[✓] VS Code
    • VS Code at /snap/code/current
    • Flutter extension version 3.22.0

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard
Copy link

flutter-dashboard bot commented May 6, 2021

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label May 6, 2021
@google-cla google-cla bot added the cla: yes label May 6, 2021
christopherfujino
christopherfujino suggested changes May 6, 2021
View reviewed changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you write a test for this change?

@TahaTesser
Copy link
Member Author

TahaTesser commented May 6, 2021

@christopherfujino
Sure, I added a test, let me know if it is invalid, writing test for tools for the first time

@TahaTesser TahaTesser changed the title [reland] Adding vscode path installed though snap [reland] Adding vscode path installed via snap May 7, 2021
christopherfujino
christopherfujino approved these changes May 11, 2021
View reviewed changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code LGTM. It looks like you have an analysis failure from trailing whitespace. The Windows failures were transitory (there was a tree-wide outage), so pushing the whitespace fix should re-trigger and they should pass.

@TahaTesser
Copy link
Member Author

TahaTesser commented May 11, 2021

@christopherfujino
Thanks so much for the review, removed whitespace, updated the branch

@christopherfujino
Copy link
Contributor

christopherfujino commented May 11, 2021

@christopherfujino
Thanks so much for the review, removed whitespace, updated the branch

thanks for making this change!

@fluttergithubbot fluttergithubbot merged commit 0d50604 into flutter:master May 12, 2021
@TahaTesser TahaTesser deleted the fix_vscode_snap_2 branch May 12, 2021 04:32
@TahaTesser TahaTesser mentioned this pull request May 12, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@christopherfujino christopherfujino christopherfujino approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

VS Code installed via Snap does not appear in flutter doctor

3 participants

@TahaTesser @christopherfujino @fluttergithubbot