Add Enter and Tab back in to ios and macos key maps #81865
Conversation
flutter-dashboard
bot
added
framework
gspencergoog
force-pushed
the
fix_tab_keycodes
branch
from
aadc3b3 to
e589242
Compare
|
@dkwingsmt I noticed when I re-ran the script that I get some differences in the generated engine code too, including some that are somewhat unexpected: I assume I should be updating those too, right? |
|
@gspencergoog I have some codegen changes collected in #81678. Let me submit that. |
gspencergoog
force-pushed
the
fix_tab_keycodes
branch
from
e589242 to
fcc4250
Compare
|
This pull request is not suitable for automatic merging in its current state.
|
dkwingsmt
left a comment
dkwingsmt
left a comment
There was a problem hiding this comment.
LGTM. I was reported this bug on macOS just now.
There was a problem hiding this comment.
Can you explain why you think this test is necessary?
There was a problem hiding this comment.
Because each PR needs to test what it is fixing.
This is testing for the failure of the generation code to generate the correct IDs for important values in keyboard navigation, which is what this PR is fixing. If one of those important values is missing or incorrect, the test will fail.
gspencergoog
force-pushed
the
fix_tab_keycodes
branch
from
985c12f to
5958a2c
Compare
3 participants
Description
I noticed that tab traversal stopped working on iOS when #73440 was landed.
It seems to be that the control characters were excluded from the list of logical keys, and so they ended up being generated values.
This PR just adds "Enter" and "Tab" to the list for both macOS and iOS.
Tests