Skip to content

Revert "Migrate to ChannelBuffers.push" #81829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
renyou merged 1 commit into from
May 4, 2021
Merged

Revert "Migrate to ChannelBuffers.push" #81829

renyou merged 1 commit into from
May 4, 2021

Conversation

@renyou
Copy link
Contributor

@renyou renyou commented May 4, 2021

Reverts #81235, it breaks Google internal tests. See b/187162385.

@renyou renyou requested review from Hixie and tvolkert May 4, 2021 13:14
@flutter-dashboard flutter-dashboard bot added a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) a: tests "flutter test", flutter_test, or one of our tests d: examples Sample code and demos f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. labels May 4, 2021
@google-cla google-cla bot added the cla: yes label May 4, 2021
@renyou
Copy link
Contributor Author

renyou commented May 4, 2021

Merge with unfinished tests, because we are very close to ToT.

@renyou renyou merged commit 7f1d141 into master May 4, 2021
@renyou renyou deleted the revert-81235-channel_buffers branch May 4, 2021 13:17
@tvolkert
Copy link
Contributor

tvolkert commented May 4, 2021

LGTM

@Hixie Hixie mentioned this pull request May 7, 2021
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Hixie Hixie Awaiting requested review from Hixie

@tvolkert tvolkert Awaiting requested review from tvolkert

Assignees

No one assigned

Labels

a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) a: tests "flutter test", flutter_test, or one of our tests c: contributor-productivity Team-specific productivity, code health, technical debt. d: examples Sample code and demos f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@renyou @tvolkert