Skip to content

[key_codegen] Remove webValues #81678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dkwingsmt merged 6 commits into from
May 10, 2021
Merged

[key_codegen] Remove webValues #81678

dkwingsmt merged 6 commits into from
May 10, 2021

Conversation

@dkwingsmt
Copy link
Contributor

@dkwingsmt dkwingsmt commented May 3, 2021 •
edited
Loading

This PR removes webValues. Web's logical mapping should map webNames to logical key values, i.e. entry.value.

This PR also includes other aesthetic changes.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label May 3, 2021
@flutter-dashboard
Copy link

flutter-dashboard bot commented May 3, 2021

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@google-cla google-cla bot added the cla: yes label May 3, 2021
@dkwingsmt dkwingsmt marked this pull request as draft May 3, 2021 11:05
@flutter-dashboard
Copy link

flutter-dashboard bot commented May 3, 2021

This pull request has been changed to a draft. The currently pending flutter-gold status will not be able to resolve until a new commit is pushed or the change is marked ready for review again.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@dkwingsmt dkwingsmt mentioned this pull request May 5, 2021
Merged
@dkwingsmt dkwingsmt changed the title [WIP] Assorted changes to key_codegen [key_codegen] Remove webValues May 5, 2021
@dkwingsmt dkwingsmt marked this pull request as ready for review May 5, 2021 01:26
@dkwingsmt dkwingsmt requested a review from gspencergoog May 5, 2021 01:26
gspencergoog
gspencergoog approved these changes May 5, 2021
View reviewed changes
Copy link
Contributor

@gspencergoog gspencergoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

This doesn't appear to fix the problem with tab and enter: was that the intention, or is this just a precursor that you want me to merge with my change?

@dkwingsmt
Copy link
Contributor Author

dkwingsmt commented May 5, 2021

@gspencergoog The latter. You said there were desynchronization between gen_keycode and the final scripts.

@dkwingsmt dkwingsmt merged commit 0e251e0 into flutter:master May 10, 2021
@dkwingsmt dkwingsmt deleted the key-codegen-trivial branch May 10, 2021 10:16
@dkwingsmt dkwingsmt added the a: text input Entering text in a text field or keyboard related problems label Jul 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gspencergoog gspencergoog gspencergoog approved these changes

Assignees

No one assigned

Labels

a: text input Entering text in a text field or keyboard related problems c: contributor-productivity Team-specific productivity, code health, technical debt.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dkwingsmt @gspencergoog