Integrate package:flutter_lints into templates #81417

goderbauer · 2021-04-28T20:35:29Z

Part of #78432.

This PR enables the recommended set of lints for Flutter apps and packages from package:flutter_lints for apps/packages/plugins created via flutter create. It also adapts those templates to ensure that they are analyzer clean under the new set of lints.

There's a bug in the linter wrt treatment of empty rules sections that is fixed upstream, but not rolled into the framework yet: dart-lang/sdk#58383

goderbauer · 2021-04-28T20:36:48Z

/cc @mit-mit @pq @devoncarew @Hixie for discussion

mit-mit

Just nits

mit-mit · 2021-04-28T20:49:58Z

packages/flutter_tools/templates/app/analysis_options.yaml.tmpl

You could link to https://dart.dev/tools#ides-and-editors

mit-mit · 2021-04-28T21:13:07Z

packages/flutter_tools/templates/app/analysis_options.yaml.tmpl

nit: consider removing the period in the url to avoid copy/paste issues

Hixie · 2021-05-04T22:38:07Z

packages/flutter_tools/templates/app/analysis_options.yaml.tmpl

nit: "practices"

Hixie · 2021-05-04T22:39:01Z

packages/flutter_tools/templates/app/analysis_options.yaml.tmpl

if we're landing before this gets fixed, let's put the TODO (and maybe the commented-out code?) somewhere where it won't get stuck in people's analysis options for years.

I will fix this before submitting it. The Fix has already landed in the Dart SDK and engine, just waiting for a roll into the framework.

Hixie · 2021-05-04T22:39:51Z

packages/flutter_tools/templates/app/lib/main.dart.tmpl

these changes are fantastic

Hixie · 2021-05-04T22:40:26Z

packages/flutter_tools/templates/app/pubspec.yaml.tmpl

"automatically upgrade" maybe?

Hixie · 2021-05-04T22:40:45Z

packages/flutter_tools/templates/app/pubspec.yaml.tmpl

Hixie · 2021-05-04T22:41:22Z

packages/flutter_tools/templates/app/pubspec.yaml.tmpl

isn't this redundant with the analysis options? i'm not sure i understand how they relate. if we really need both we should definitely explain the difference in these files.

Reworded the paragraph above. This line just makes the set of recommended lints available. The import in the analysis_options.yaml then activates that set.

pq

🚀

jonahwilliams · 2021-05-06T01:05:38Z

packages/flutter_tools/templates/app/lib/main.dart.tmpl

Does this conflict with the private return types lint? Or is that not in the recommended set

That's not in the recommended set.

jonahwilliams

LGTM

goderbauer · 2021-05-06T16:59:49Z

Thank you!

Submission is now blocked on the tree becoming green and dart-lang/sdk#58383 rolling into the framework.

devoncarew · 2021-05-06T17:14:16Z

Thank you!

Submission is now blocked on the tree becoming green and dart-lang/sdk#58383 rolling into the framework.

I believe the fix for this landed in dart-lang/sdk (dart-lang/sdk@f193637) ~8 days ago, so should likely already be available in flutter/flutter.

goderbauer · 2021-05-06T17:19:51Z

I believe the fix for this landed in dart-lang/sdk (dart-lang/sdk@f193637) ~8 days ago, so should likely already be available in flutter/flutter.

While the fix has rolled into the engine, it's not available in flutter/flutter yet due to an unfortunate combination of engine rollbacks and tree closures. I believe the next engine roll into the framework will contain the fix, though, once the tree is open again.

My newly added tests is actually currently failing because the fix is not rolled in yet: https://github.com/flutter/flutter/pull/81417/checks?check_run_id=2520340935

dnfield · 2021-05-10T23:53:50Z

This broke skp_generator tests.

This reverts commit 532a79c.

goderbauer · 2021-05-11T00:04:32Z

This broke skp_generator tests.

Could parts of that test run presubmit (e.g. at least analyzing the code) to avoid this in the future?

Hixie · 2021-05-11T06:24:34Z

skp_generator should already be running presubmit

Hixie · 2021-05-11T06:25:04Z

I don't see it there though, weird.

Hixie · 2021-05-11T06:25:43Z

It was added in #81096

Hixie · 2021-05-11T06:27:40Z

Fix in #82239

Hixie · 2021-10-05T06:59:31Z

packages/flutter_tools/test/commands.shard/permeable/create_test.dart

-  expect(exec.exitCode, 0);
+  expect(exec.exitCode, isNot(0));
+  String lineParser(String line) {
+    print('#$line#');


was this a temporary debugging line that leaked in?

Oh, yeah. Will send PR to remove.

flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Apr 28, 2021

google-cla bot added the cla: yes label Apr 28, 2021

goderbauer mentioned this pull request Apr 28, 2021

☂️ Update lint set for Flutter applications #78432

Closed

15 tasks

mit-mit reviewed Apr 28, 2021

View reviewed changes

goderbauer force-pushed the lints branch from b7d4891 to 1267e4b Compare May 4, 2021 21:19

Hixie reviewed May 4, 2021

View reviewed changes

packages/flutter_tools/templates/app/analysis_options.yaml.tmpl Outdated

Copy link

Contributor

Hixie May 4, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: "practices"

goderbauer reacted with thumbs up emoji

Hixie reviewed May 4, 2021

View reviewed changes

packages/flutter_tools/templates/app/lib/main.dart.tmpl Outdated

Copy link

Contributor

Hixie May 4, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these changes are fantastic

goderbauer reacted with rocket emoji

Hixie reviewed May 4, 2021

View reviewed changes

packages/flutter_tools/templates/app/pubspec.yaml.tmpl Outdated

Copy link

Contributor

Hixie May 4, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

practices

goderbauer reacted with thumbs up emoji

Hixie reviewed May 4, 2021

View reviewed changes

goderbauer changed the title ~~Integrate package:lints into templates~~ Integrate package:flutter_lints into templates May 5, 2021

goderbauer marked this pull request as ready for review May 6, 2021 00:09

goderbauer requested review from devoncarew, jonahwilliams and mit-mit May 6, 2021 00:10

pq approved these changes May 6, 2021

View reviewed changes

jonahwilliams reviewed May 6, 2021

View reviewed changes

jonahwilliams approved these changes May 6, 2021

View reviewed changes

mit-mit approved these changes May 6, 2021

View reviewed changes

devoncarew approved these changes May 6, 2021

View reviewed changes

devoncarew mentioned this pull request May 6, 2021

update the 'dart create' templates to reference the new package:lints lint set dart-lang/sdk#45940

Closed

goderbauer force-pushed the lints branch from ac086bb to fbb20ad Compare May 6, 2021 16:58

goderbauer mentioned this pull request May 6, 2021

Migration guide for package:flutter_lints flutter/website#5749

Merged

3 tasks

goderbauer force-pushed the lints branch from fbb20ad to fa869b8 Compare May 6, 2021 23:19

goderbauer added the waiting for tree to go green label May 6, 2021

goderbauer added 12 commits May 10, 2021 11:07

adopt to flutter_lints

dadcffe

++

a8ce81d

++

47f5706

wording

2f26cd5

more tests

21a8531

use flutter_lints: ^1.0.0-dev.0

9719d9d

test fix

5351deb

remove print

da671d6

Remove work-around for https://github.com/dart-lang/linter/issues/2612

2be201f

update version

00094ba

tpyo

b94d793

fix test on windows

8bab42f

goderbauer force-pushed the lints branch from ba22af6 to 8bab42f Compare May 10, 2021 18:14

goderbauer added the waiting for tree to go green label May 10, 2021

fluttergithubbot merged commit 532a79c into flutter:master May 10, 2021

goderbauer mentioned this pull request May 10, 2021

clean-up analysis_options.yaml's across the repository #81986

Merged

dnfield added a commit that referenced this pull request May 10, 2021

Revert "Integrate package:flutter_lints into templates (#81417)"

e3248ff

This reverts commit 532a79c.

dnfield mentioned this pull request May 10, 2021

Revert "Integrate package:flutter_lints into templates" #82233

Closed

goderbauer deleted the lints branch May 11, 2021 00:03

goderbauer mentioned this pull request May 19, 2021

Deprecate analysis_options_user.yaml #82948

Closed

darshankawar mentioned this pull request Jul 2, 2021

Imports to analysis_options.yaml are not considered if it contains empty 'linter:' #78535

Closed

Sunbreak mentioned this pull request Aug 27, 2021

Should the new template include an analysis_options.yaml? brianegan/new_flutter_template#5

Open

Hixie reviewed Oct 5, 2021

View reviewed changes

goderbauer mentioned this pull request Oct 5, 2021

Remove accidental print #91317

Merged

Integrate package:flutter_lints into templates #81417

Integrate package:flutter_lints into templates #81417

Uh oh!

Conversation

goderbauer commented Apr 28, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

goderbauer commented Apr 28, 2021

Uh oh!

mit-mit left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pq left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jonahwilliams left a comment

Choose a reason for hiding this comment

Uh oh!

goderbauer commented May 6, 2021

Uh oh!

devoncarew commented May 6, 2021

Uh oh!

goderbauer commented May 6, 2021

Uh oh!

dnfield commented May 10, 2021

Uh oh!

goderbauer commented May 11, 2021

Uh oh!

Hixie commented May 11, 2021

Uh oh!

Hixie commented May 11, 2021

Uh oh!

Hixie commented May 11, 2021

Uh oh!

Hixie commented May 11, 2021

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

goderbauer commented Apr 28, 2021 •

edited

Loading