Skip to content

Remove Finder extended attributes before code signing iOS frameworks #81342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jmagman merged 2 commits into from
Apr 28, 2021
Merged

Remove Finder extended attributes before code signing iOS frameworks #81342

jmagman merged 2 commits into from
Apr 28, 2021

Conversation

@jmagman
Copy link
Member

@jmagman jmagman commented Apr 27, 2021

Remove the com.apple.FinderInfo extended attributes from frameworks copied into the app before it is codesigned.

Similar to #54488
Fixes #80978

@jmagman jmagman added platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels. t: xcode "xcodebuild" on iOS and general Xcode project management labels Apr 27, 2021
@jmagman jmagman self-assigned this Apr 27, 2021
@google-cla google-cla bot added the cla: yes label Apr 27, 2021
@jmagman jmagman mentioned this pull request Apr 28, 2021
Closed
christopherfujino
christopherfujino approved these changes Apr 28, 2021
View reviewed changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmagman jmagman merged commit d2b0687 into flutter:master Apr 28, 2021
@jmagman jmagman deleted the xattr branch April 28, 2021 18:05
@jmagman jmagman mentioned this pull request Apr 29, 2021
Merged
This was referenced Mar 31, 2023
Open
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@christopherfujino christopherfujino christopherfujino approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jmagman jmagman

Labels

platform-ios iOS applications specifically t: xcode "xcodebuild" on iOS and general Xcode project management tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

2 participants

@jmagman @christopherfujino