Skip to content

Migrate to ChannelBuffers.push #81235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluttergithubbot merged 4 commits into from
May 4, 2021
Merged

Migrate to ChannelBuffers.push #81235

fluttergithubbot merged 4 commits into from
May 4, 2021

Conversation

@Hixie
Copy link
Contributor

@Hixie Hixie commented Apr 26, 2021 •
edited
Loading

This is a reland of #76288 which was reverted in #81226 due to google3 issues. Those should be solved by cl/370540746.

Also includes code to remove a legacy TODO whose referenced issue (#51885) is now closed.

See #77454, #79061, and #80003 for earlier discussions. This was last reverted in #81316.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) a: tests "flutter test", flutter_test, or one of our tests d: examples Sample code and demos f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. labels Apr 26, 2021
@google-cla google-cla bot added the cla: yes label Apr 26, 2021
This was referenced Apr 26, 2021
Merged
Merged
@Hixie Hixie force-pushed the channel_buffers branch 4 times, most recently from 3e26b14 to 0282f0c Compare April 27, 2021 19:28
@Hixie Hixie force-pushed the channel_buffers branch from 0282f0c to 5d728c7 Compare May 1, 2021 09:41
@Hixie
Copy link
Contributor Author

Hixie commented May 2, 2021

cc @goderbauer who reviewed the previous PRs that this lands; this does not have any code changes from the last two PRs that landed as far as I am aware.

@tvolkert
Copy link
Contributor

tvolkert commented May 3, 2021

RSLGTM (reland)

@fluttergithubbot
Copy link
Contributor

fluttergithubbot commented May 3, 2021

This pull request is not suitable for automatic merging in its current state.

  • Please get at least one approved review before re-applying this label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

@fluttergithubbot fluttergithubbot merged commit 35ad43f into flutter:master May 4, 2021
renyou added a commit that referenced this pull request May 4, 2021
@renyou
Revert "Migrate to ChannelBuffers.push (#81235)"
498372e 
This reverts commit 35ad43f.
@renyou renyou mentioned this pull request May 4, 2021
Merged
renyou added a commit that referenced this pull request May 4, 2021
@renyou
Revert "Migrate to ChannelBuffers.push (#81235)" (#81829)
7f1d141 
This reverts commit 35ad43f.
@Hixie Hixie mentioned this pull request May 7, 2021
Merged
8 tasks
Hixie added a commit to Hixie/flutter that referenced this pull request May 14, 2021
@Hixie
Migrate to ChannelBuffers.push
f536a68 
* Moves the handlePlatformMessage logic to using ChannelBuffers.
* Moves the testing APIs from services library to flutter_test.
* Refactors text editing test APIs.
* This is a reland of flutter#76288 and flutter#78637.

See flutter#77454, flutter#79061, flutter#80003, flutter#81235, and flutter#82057 for earlier discussions. This was last reverted in flutter#82525.
@Hixie Hixie mentioned this pull request May 14, 2021
Merged
8 tasks
Hixie added a commit to Hixie/flutter that referenced this pull request May 21, 2021
@Hixie
Migrate to ChannelBuffers.push
a87a5f5 
* Moves the handlePlatformMessage logic to using ChannelBuffers.
* Moves the testing APIs from services library to flutter_test.
* Refactors text editing test APIs.
* This is a reland of flutter#76288 and flutter#78637.

See flutter#77454, flutter#79061, flutter#80003, flutter#81235, and flutter#82057 for earlier discussions. This was last reverted in flutter#82525.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@tvolkert tvolkert tvolkert approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) a: tests "flutter test", flutter_test, or one of our tests c: contributor-productivity Team-specific productivity, code health, technical debt. d: examples Sample code and demos f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Hixie @tvolkert @fluttergithubbot