Skip to content

Revert "Migrate to ChannelBuffers.push" #81226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
angjieli merged 1 commit into from
Apr 26, 2021
Merged

Revert "Migrate to ChannelBuffers.push" #81226

angjieli merged 1 commit into from
Apr 26, 2021

Conversation

@angjieli
Copy link
Contributor

@angjieli angjieli commented Apr 26, 2021

Reverts #76288. Causing bugs in Google3.

@flutter-dashboard flutter-dashboard bot added a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) a: tests "flutter test", flutter_test, or one of our tests d: examples Sample code and demos f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. labels Apr 26, 2021
@angjieli angjieli requested a review from Hixie April 26, 2021 18:52
@google-cla google-cla bot added the cla: yes label Apr 26, 2021
Hixie
Hixie approved these changes Apr 26, 2021
View reviewed changes
Copy link
Contributor

@Hixie Hixie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@angjieli angjieli merged commit b74df38 into master Apr 26, 2021
@angjieli angjieli deleted the revert-76288-dispatch2 branch April 26, 2021 19:57
@Hixie Hixie mentioned this pull request Apr 26, 2021
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Hixie Hixie Hixie approved these changes

Assignees

No one assigned

Labels

a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) a: tests "flutter test", flutter_test, or one of our tests c: contributor-productivity Team-specific productivity, code health, technical debt. d: examples Sample code and demos f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@angjieli @Hixie